Review Request 126453: Fix library order

Hrvoje Senjan hrvoje.senjan at gmail.com
Mon Dec 21 21:45:13 UTC 2015



> On Dec. 21, 2015, 5:33 p.m., Hrvoje Senjan wrote:
> > A public header here (DownloadWidget) includes QWidget
> 
> Kevin Funk wrote:
>     Qt5::Widgets is still in PUBLIC scope

Oops, i could swear i've seen it moved into PRIVATE section. Ignore.


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126453/#review89837
-----------------------------------------------------------


On Dec. 21, 2015, 5:06 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126453/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2015, 5:06 p.m.)
> 
> 
> Review request for KDE Frameworks, Heiko Becker and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> Fixes issues leading to creation of QTBUG-47240
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt cc606444e48b0e519551183c022ccecdac0aa62f 
> 
> Diff: https://git.reviewboard.kde.org/r/126453/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151221/bfa1e45b/attachment.html>


More information about the Kde-frameworks-devel mailing list