Review Request 126455: Add mutex round static QRegExp usage in KShorturifilter

[Alex Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126455/#review89862
-----------------------------------------------------------


Maybe use QRegularExpression instead? It already [has a mutex internally](http://code.woboq.org/qt5/qtbase/src/corelib/tools/qregularexpression.cpp.html#_ZN25QRegularExpressionPrivate14compilePatternEv) and is the replacement for QRegExp

- Alex Richardson


On Dec. 21, 2015, 4:22 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126455/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2015, 4:22 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 352356
>     https://bugs.kde.org/show_bug.cgi?id=352356
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> QRegExp is reentrrant, but it is not thread safe.
> 
> BUG: 352356
> 
> 
> Diffs
> -----
> 
>   src/urifilters/shorturi/kshorturifilter.cpp 1af4768b7b5ab9d1f5af52f17170d466d854b9bb 
> 
> Diff: https://git.reviewboard.kde.org/r/126455/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151221/9e688fcf/attachment.html>