Review Request 126426: Add a warning color to kwalletd's password dialogs
Martin Klapetek
martin.klapetek at gmail.com
Mon Dec 21 19:15:47 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126426/#review89846
-----------------------------------------------------------
+1, looks good to me.
- Martin Klapetek
On Dec. 19, 2015, 12:59 p.m., Elvis Angelaccio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126426/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2015, 12:59 p.m.)
>
>
> Review request for KDE Frameworks and Valentin Rusu.
>
>
> Repository: kwallet
>
>
> Description
> -------
>
> Set a "background warning color" when password and its verification do not match, in the KNewPasswordDialog run by kwalletd.
> This adds a new dependency (needed to avoid hardcoding colors), but I think is a nice feature to have.
> See RR 125619 for a screenshot: https://git.reviewboard.kde.org/r/125619/file/2515/
>
>
> Diffs
> -----
>
> src/runtime/kwalletd/CMakeLists.txt ba9e7ba508c74fed1d8101496583061245640aa7
> src/runtime/kwalletd/kwalletd.cpp 6da97031e13240a9630cfa7e0dc3cf42575819c4
>
> Diff: https://git.reviewboard.kde.org/r/126426/diff/
>
>
> Testing
> -------
>
> Compiles fine.
>
>
> Thanks,
>
> Elvis Angelaccio
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151221/88872bb2/attachment.html>
More information about the Kde-frameworks-devel
mailing list