Review Request 126423: KPluginSelector::addPlugins: do not assert if 'config' parameter is null

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126423/
-----------------------------------------------------------

(Updated Dec. 21, 2015, 8:55 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 1ae59b5f0ea4f50b7350f03fd2b1fe223f66a261 by Jonathan Marten to branch master.


Bugs: 352471
    https://bugs.kde.org/show_bug.cgi?id=352471


Repository: kcmutils


Description
-------

The API documentation says that the 4-argument form of KPluginSelector::addPlugins() can be called with the last 'config' parameter as null (the default), meaning the standard application config file.  However, there seems to be a misplaced assert which means that this will not be accepted.


Diffs
-----

  src/kpluginselector.cpp 34a7897 

Diff: https://git.reviewboard.kde.org/r/126423/diff/


Testing
-------

Built kcmutils with this change, checked with Konqueror's "Configure Extensions" dialogue as described in the bug report.  Observed assert/crash without this change, and correct operation with it.


Thanks,

Jonathan Marten

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151221/a5c1cbe8/attachment.html>