Review Request 126429: Fixed all Clazy warnings level 1 and level 2
Artur Puzio
cytadela88 at gmail.com
Sat Dec 19 18:22:25 UTC 2015
> On Gru 19, 2015, 4:55 po południu, Aleix Pol Gonzalez wrote:
> > In general I don't like commented code. Why keep it?
> > David, do you think we should keep it?
> >
> > Artur, have you made sure the tests still pass? It doesn't say so in the testing field.
Sorry I have forgotten to submit Testing Done fild.
- Artur
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126429/#review89746
-----------------------------------------------------------
On Gru 19, 2015, 4:56 po południu, Artur Puzio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126429/
> -----------------------------------------------------------
>
> (Updated Gru 19, 2015, 4:56 po południu)
>
>
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
>
>
> Repository: karchive
>
>
> Description
> -------
>
> Fixed warning: Folder has dtor but not copy-ctor, copy-assignment [-Wclazy-rule-of-three], by adding Q_DISABLE_COPY(Folder)
> Fixed warning: Reserve candidate [-Wclazy-reserve-candidates], by precalculateing QVector size.
> Fixed warning: unused variable [-Wunused-const-variable], by commenting unused variables
>
>
> Diffs
> -----
>
> src/k7zip.cpp 7b5e6a3
>
> Diff: https://git.reviewboard.kde.org/r/126429/diff/
>
>
> Testing
> -------
>
> Automated tests pass.
>
>
> Thanks,
>
> Artur Puzio
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151219/0bc2e57e/attachment.html>
More information about the Kde-frameworks-devel
mailing list