Review Request 126416: MetaFunction doesn't need to be exported
Aleix Pol Gonzalez
aleixpol at kde.org
Fri Dec 18 14:17:19 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126416/#review89711
-----------------------------------------------------------
Maybe it would be best to move the implementation to a .cpp file?
- Aleix Pol Gonzalez
On Dec. 18, 2015, 3:05 p.m., Patrick Spendrin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126416/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 3:05 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kross
>
>
> Description
> -------
>
> Header only functions don't need to be exported, as there is no code in
> the dynamic library available.
>
>
> Diffs
> -----
>
> src/core/metafunction.h 71ce3470ca627f4d2b90b5cdd94cfe87a41c9a8f
>
> Diff: https://git.reviewboard.kde.org/r/126416/diff/
>
>
> Testing
> -------
>
> Windows.
>
>
> Thanks,
>
> Patrick Spendrin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151218/a8bbccd1/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list