Review Request 126327: sonnet: Do not use QStringLiteral with multi strings

[Patrick Spendrin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126327/
-----------------------------------------------------------

(Updated Dec. 18, 2015, 1:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Changes
-------

Submitted with commit 738ccd36971aadbd9fe85d09e4087c64a2a604ad by Patrick R. Spendrin to branch master.


Repository: sonnet


Description
-------

Strings that are separated into multiple parts don't work on Windows
together with QStringLiteral as the first string is interpreted as a
wide (16bit) string, and the second one as a narrow (8bit) string.
Replacing with QString::fromLatin1 is the easiest solution keeping
the code layout the same, joining the strings does work too though.


Diffs
-----

  examples/dialogexample.cpp 4bda1ad4c2e8df1d51e7007838fbc43747919304 
  examples/plaintextedit.cpp 45b5503612cbdb32796228bcee1b53a472e9d313 
  examples/textedit.cpp a1ccb28aab35e2491b1512241a05767429ce84d9 

Diff: https://git.reviewboard.kde.org/r/126327/diff/


Testing
-------

Windows.


Thanks,

Patrick Spendrin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151218/28f7e63f/attachment.html>