Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

Martin Gräßlin mgraesslin at kde.org
Thu Dec 17 08:06:38 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126397/
-----------------------------------------------------------

Review request for KDE Frameworks, kwin and Albert Astals Cid.


Bugs: 354811
    https://bugs.kde.org/show_bug.cgi?id=354811


Repository: kwindowsystem


Description
-------

We observed that with Compiz as window manager various applications
crash if they use QGuiApplication instead of QApplication. The reason
for this is that on Compiz the mapViewport code paths are used and
that has a widgets dependency.

This change should ensure that applications do at least not crash
in this condition.

BUG: 354811


Diffs
-----

  src/platforms/xcb/kwindowsystem.cpp 9d287043c24894ca3c29c439c7939b139da055e8 

Diff: https://git.reviewboard.kde.org/r/126397/diff/


Testing
-------

Compiz not available on Debian, cannot test.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151217/9cdc319f/attachment.html>


More information about the Kde-frameworks-devel mailing list