Review Request 126384: better description of qmlmodule cmake module
Jonathan Riddell
jr at jriddell.org
Wed Dec 16 14:42:07 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126384/
-----------------------------------------------------------
(Updated Dec. 16, 2015, 2:42 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Changes
-------
Submitted with commit 166ea0ed7877c47aa89eed03d00f5d1ed15424a6 by Jonathan Riddell to branch master.
Repository: purpose
Description
-------
don't say it's failed as a description, just say what it's looking for. currently it says it's failed even when it's found what it needs
Diffs
-----
src/plugins/cmake/FindQMLModule.cmake 63c3542
Diff: https://git.reviewboard.kde.org/r/126384/diff/
Testing
-------
run it with and without qmlplugindump installed, it now no longer says it's failed even when it hasn't
Thanks,
Jonathan Riddell
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151216/c1ea1fc0/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list