Review Request 126384: better description of qmlmodule cmake module
Jonathan Riddell
jr at jriddell.org
Wed Dec 16 12:43:49 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126384/
-----------------------------------------------------------
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Repository: purpose
Description
-------
don't say it's failed as a description, just say what it's looking for. currently it says it's failed even when it's found what it needs
Diffs
-----
src/plugins/cmake/FindQMLModule.cmake 63c3542
Diff: https://git.reviewboard.kde.org/r/126384/diff/
Testing
-------
run it with and without qmlplugindump installed, it now no longer says it's failed even when it hasn't
Thanks,
Jonathan Riddell
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151216/aa77f7e8/attachment.html>
More information about the Kde-frameworks-devel
mailing list