Review Request 126325: kwidgetsaddons: Do not use QStringLiteral with multi strings

[Patrick Spendrin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126325/
-----------------------------------------------------------

(Updated Dec. 16, 2015, 8:27 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Christoph Feck.


Changes
-------

Submitted with commit 71dd42f902c8fa09f6eca5e762c2e46a45161767 by Patrick R. Spendrin on behalf of Patrick Spendrin to branch master.


Repository: kwidgetsaddons


Description
-------

Strings that are separated into multiple parts don't work on Windows
together with QStringLiteral as the first string is interpreted as a
wide (16bit) string, and the second one as a narrow (8bit) string.
Replacing with QString::fromLatin1 is the easiest solution keeping
the code layout the same, joining the strings would work too though.


Diffs
-----

  src/kmessagewidget.cpp b8070880dc2e7e9fd8c6c9be7f0087d4da83b413 
  tests/kmessageboxtest.cpp 73e5f7acf297eb9fb39bbcaf03f79ff9e17e29ac 

Diff: https://git.reviewboard.kde.org/r/126325/diff/


Testing
-------

Windows.


Thanks,

Patrick Spendrin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151216/dcb3bdb4/attachment.html>