Review Request 126326: kdbusaddons: Do not use QStringLiteral with multi strings

Patrick Spendrin ps_ml at gmx.de
Wed Dec 16 08:21:16 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126326/
-----------------------------------------------------------

(Updated Dec. 16, 2015, 8:21 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 11ef653e0393b2890e932d6ced4d5ef4d1781e93 by Patrick R. Spendrin to branch master.


Repository: kdbusaddons


Description
-------

Strings that are separated into multiple parts don't work on Windows
together with QStringLiteral as the first string is interpreted as a
wide (16bit) string, and the second one as a narrow (8bit) string.
Replacing with QString::fromLatin1 is the easiest solution keeping
the code layout the same, joining the strings would work too though.


Diffs
-----

  src/kdbusservice.cpp d17bfd2b971d462cc9ddea37624f1e71c7d0f16e 

Diff: https://git.reviewboard.kde.org/r/126326/diff/


Testing
-------

Windows.


Thanks,

Patrick Spendrin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151216/cac793c2/attachment.html>


More information about the Kde-frameworks-devel mailing list