Review Request 126366: Make KPluginMetaData constructible from a json path.

[Alex Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126366/#review89555
-----------------------------------------------------------

Ship it!


If you have time, a minimal unit test would be nice to make sure we don't break this in future.

- Alex Richardson


On Dec. 15, 2015, 3:27 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126366/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 3:27 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Loads the json file upon construction. Simplifies adoption of json metadata files for KPackage.
> 
> 
> Diffs
> -----
> 
>   src/lib/plugin/kpluginmetadata.h a91b94a 
>   src/lib/plugin/kpluginmetadata.cpp 3674360 
> 
> Diff: https://git.reviewboard.kde.org/r/126366/diff/
> 
> 
> Testing
> -------
> 
> Tests still pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151215/a1f0628e/attachment.html>