Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126320/
-----------------------------------------------------------

(Updated Dec. 14, 2015, 2:05 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma and Alex Richardson.


Changes
-------

Submitted with commit 54602237fd018a7212cadea5210a1908584ee110 by Martin Klapetek to branch master.


Repository: plasma-framework


Description
-------

plasma-scriptengine.desktop defines the property "X-Plasma-ComponentTypes"
as Type=QStringList. When reading it using KPluginMetaData::value(..) it
expects a QString back. This used to work but regressed in kcoreaddons in
commit cfd18cf09b559a050fd6a2680ad4e71eeb950383. Now I'm not sure if calling
KPluginMetaData::value(..) on a property that is known to be a stringlist
should actually return a QString (Alex?), but making it read the property
as a stringlist works and is correct and also fixes Plasma startup for me.


Diffs
-----

  src/plasma/scripting/scriptengine.cpp 1b132de 

Diff: https://git.reviewboard.kde.org/r/126320/diff/


Testing
-------

Plasma would get stuck on startup, now I can run Plasma again.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151214/db14afd4/attachment.html>