Review Request 126339: remove kdewin dependency

[Alex Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126339/#review89464
-----------------------------------------------------------

Ship it!


Looks good to me

- Alex Richardson


On Dec. 14, 2015, 10:37 a.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126339/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2015, 10:37 a.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: khtml
> 
> 
> Description
> -------
> 
> This removes the direct kdewin dependency by replacing problematic
> function calls (uname, snprintf) with their Qt counterparts.
> Some leftover unix header includes removed too.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 51fe02a01c8166046d1c6085ec4a5b6e617e1fea 
>   src/ecma/kjs_binding.cpp 5e122f0f0d70e6734565e7ab205d14a92c79d287 
>   src/ecma/kjs_navigator.cpp 2f7be8d11e5af84e08ac640ccbc97f70aeac8abd 
>   src/ecma/kjs_proxy.h 24abd1e1bac0932f8829f02185953142c74aadc8 
>   src/ecma/kjs_proxy.cpp 20430f48fce986ca654c49c5771ad839845f11ab 
>   src/khtml_pagecache.cpp 8e1841f6b0e816dfd8faa76f2191b269c4716011 
>   src/khtml_part.cpp adbcd800a526e9f8fd92a553e62ee64791872938 
>   src/kmultipart/kmultipart.cpp 1ad3bbb9b6d6a022799d5ef85f426fc9f911d45b 
> 
> Diff: https://git.reviewboard.kde.org/r/126339/diff/
> 
> 
> Testing
> -------
> 
> Windows, Linux compiles.
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151214/c98fef2a/attachment.html>