Review Request 126329: kio: Do not use QStringLiteral with multi strings

[Patrick Spendrin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126329/
-----------------------------------------------------------

(Updated Dec. 14, 2015, 9:43 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit da70a9c7fee17a304526aad60be749e5701dea95 by Patrick R. Spendrin to branch master.


Repository: kio


Description
-------

Strings that are separated into multiple parts don't work on Windows
together with QStringLiteral as the first string is interpreted as a
wide (16bit) string, and the second one as a narrow (8bit) string.
Replacing with QString::fromLatin1 is the easiest solution keeping
the code layout the same, joining the strings does work too though.


Diffs
-----

  autotests/dataprotocoltest.cpp 9fe238fdbb0e9682141772d423a64edd5621921b 
  src/core/ksambashare.cpp a3f84ac3971141e687d9ab17e0131a66db34ed5a 
  src/filewidgets/kfileplacesmodel.cpp b409c1b1617f97f3cdbc79a2c76110a5f9449398 
  src/ioslaves/help/kio_help.cpp cb27a77b22fe378a126d985621985265edb93767 
  src/widgets/kpropertiesdialog.cpp 0ff506273a10dba238fefc5c552c71434681285e 

Diff: https://git.reviewboard.kde.org/r/126329/diff/


Testing
-------

Windows.


Thanks,

Patrick Spendrin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151214/dde1322b/attachment-0001.html>