Review Request 126325: kwidgetsaddons: Do not use QStringLiteral with multi strings

[Patrick Spendrin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126325/
-----------------------------------------------------------

(Updated Dez. 13, 2015, 10:38 nachm.)


Review request for KDE Frameworks and Christoph Feck.


Summary (updated)
-----------------

kwidgetsaddons: Do not use QStringLiteral with multi strings


Repository: kwidgetsaddons


Description
-------

Strings that are separated into multiple parts don't work on Windows
together with QStringLiteral as the first string is interpreted as a
wide (16bit) string, and the second one as a narrow (8bit) string.
Replacing with QString::fromLatin1 is the easiest solution keeping
the code layout the same, joining the strings would work too though.


Diffs
-----

  src/kmessagewidget.cpp b8070880dc2e7e9fd8c6c9be7f0087d4da83b413 
  tests/kmessageboxtest.cpp 73e5f7acf297eb9fb39bbcaf03f79ff9e17e29ac 

Diff: https://git.reviewboard.kde.org/r/126325/diff/


Testing
-------

Windows.


Thanks,

Patrick Spendrin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151213/dadcbd3c/attachment-0001.html>