Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Sat Dec 12 21:49:24 UTC 2015



> On Dec. 12, 2015, 10:02 p.m., David Faure wrote:
> > Ah I needed the last hunk from your patch, too. Now it works. http://www.davidfaure.fr/2015/0001-Add-autocompletion-for-.-input-which-offers-all-hidd.patch ok with you?

LGTM, thanks! :)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125988/#review89400
-----------------------------------------------------------


On Nov. 28, 2015, 10:36 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125988/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2015, 10:36 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 354981
>     https://bugs.kde.org/show_bug.cgi?id=354981
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Currently KUrlCompletion only offers autocompletion for hidden folders when you input at least one additional character after the dot. 
> With this patch all hidden folders will be offered when only a dot is present.
> 
> This behaviour is test covered.
> 
> 
> Diffs
> -----
> 
>   autotests/kurlcompletiontest.cpp ca8563c 
>   src/widgets/kurlcompletion.cpp c6764e4 
> 
> Diff: https://git.reviewboard.kde.org/r/125988/diff/
> 
> 
> Testing
> -------
> 
> All test cases for KUrlCompletion pass
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151212/661e2526/attachment.html>


More information about the Kde-frameworks-devel mailing list