Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

[David Faure]

> On Dec. 12, 2015, 11:12 a.m., David Faure wrote:
> > Either that, or if you want the fix to be available before 5.6 is out, wrap your fix with #if QT_VERSION < QT_VERSION_CHECK(5, 6, 0).
> > 
> > We can always clean it up once 5.6 is required (i.e. in a few years ;).
> > And mention the qt fix in a comment of course.
> > 
> > I don't mind which way around you choose to go.

Ah right the "fix" isn't just the if/else but also the added member vars. Let's not have that in, too messy.

Hmm. But your autotest doesn't pass even with my fix. I'll debug this...


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125988/#review89381
-----------------------------------------------------------


On Nov. 28, 2015, 9:36 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125988/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2015, 9:36 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 354981
>     https://bugs.kde.org/show_bug.cgi?id=354981
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Currently KUrlCompletion only offers autocompletion for hidden folders when you input at least one additional character after the dot. 
> With this patch all hidden folders will be offered when only a dot is present.
> 
> This behaviour is test covered.
> 
> 
> Diffs
> -----
> 
>   autotests/kurlcompletiontest.cpp ca8563c 
>   src/widgets/kurlcompletion.cpp c6764e4 
> 
> Diff: https://git.reviewboard.kde.org/r/125988/diff/
> 
> 
> Testing
> -------
> 
> All test cases for KUrlCompletion pass
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151212/5400dcba/attachment.html>