Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

[Emmanuel Pescosta]

> On Dec. 6, 2015, 12:19 p.m., David Faure wrote:
> > OK I debugged this further, and I found why this didn't match my expectations of the QUrl behaviour:
> > 
> > QUrl::fromLocalFile("/tmp/.") leads to file:///tmp rather than file:///tmp/. I consider this a bug (when NormalizePathSegments isn't set), I'll discuss it with Thiago and possibly fix it in Qt.
> 
> David Faure wrote:
>     Urgh, it's my own commit aba336c2b4ad8926dc8a000718bbb7f8a6d5a72d in qurl.cpp ...
> 
> David Faure wrote:
>     Suggested fix posted to https://codereview.qt-project.org/143134

Nice. Thanks for fixing it in Qt :)

So how should we proceed with this RR?
Wrap all "." test cases with a #if QT_VERSION >= QT_VERSION_CHECK(5, 6, 0)?


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125988/#review89168
-----------------------------------------------------------


On Nov. 28, 2015, 10:36 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125988/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2015, 10:36 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 354981
>     https://bugs.kde.org/show_bug.cgi?id=354981
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Currently KUrlCompletion only offers autocompletion for hidden folders when you input at least one additional character after the dot. 
> With this patch all hidden folders will be offered when only a dot is present.
> 
> This behaviour is test covered.
> 
> 
> Diffs
> -----
> 
>   autotests/kurlcompletiontest.cpp ca8563c 
>   src/widgets/kurlcompletion.cpp c6764e4 
> 
> Diff: https://git.reviewboard.kde.org/r/125988/diff/
> 
> 
> Testing
> -------
> 
> All test cases for KUrlCompletion pass
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151212/2c2ef6d1/attachment.html>