Review Request 126185: Make the KAppTemplate CMake module global

[Aleix Pol Gonzalez]

> On Dec. 9, 2015, 1:03 p.m., Aleix Pol Gonzalez wrote:
> > kde-modules/KDETemplateGenerator.cmake, line 59
> > <https://git.reviewboard.kde.org/r/126185/diff/3/?file=421456#file421456line59>
> >
> >     Naming them .zip on windows, won't make it a zip file, if you use tar j. I suggest just using .tar.bz2 everywhere.
> 
> Marco Martin wrote:
>     is it guaranteed that the .tar.bz2 file will be correctly generated on windows too?

cmake generates it, so yes. I'm less sure of whether .tar.bz2 is available commonly on windows on runtime, but we're talking project templates anyway, so it should be fine.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126185/#review89275
-----------------------------------------------------------


On Dec. 9, 2015, 1:12 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126185/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 1:12 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Simon Wächter.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> templates are very useful as teaching tool in order to make
> a minimal application that uses a certain framework.
> templates in the KAppTemplate repository will always get forgotten
> (plus kapptemplate is not really necessary as they work in kdevelop as well)
> An ideal situation would be frameworks having templates in their own repos
> with templates of barebone apps using the main framework features.
> In order to do that, the cmake stuff needed in order to correctly install
> a template needs to be ported to a place avaiable to all frameworks
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDETemplateGenerator.cmake PRE-CREATION 
>   kde-modules/KDEInstallDirs.cmake b7cd34d 
> 
> Diff: https://git.reviewboard.kde.org/r/126185/diff/
> 
> 
> Testing
> -------
> 
> done some templates installed by plasma-framework
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151209/480bddeb/attachment.html>