Review Request 125869: Convert all io slave .protocol data to json and embed it.

[Andrew McCann]

> On Nov. 3, 2015, 9:47 p.m., Albert Astals Cid wrote:
> > How does this work without modifying KProtocolInfoPrivate::KProtocolInfoPrivate?
> 
> Christoph Cullmann wrote:
>     You mean the JSON stuff? That was implemented in https://git.reviewboard.kde.org/r/125830/
>     For the http slave, that already works nicely, but we missed that "ExtraNames" as used by other slaves need i18n care.
> 
> Albert Astals Cid wrote:
>     i see, i did not see that there's two almost copied KProtocolInfoPrivate::KProtocolInfoPrivate implementations
>     
>     So the json magic stuff (you can see ./src/ioslaves/http/kcookiejar/kcookiejar.json in kio) only works for Description and Name inside KPlugin, someone would need to update createjsoncontext.py and filljsonfrompo.py so they also take into account ExtraNames inside childs of "KDE-KIO-Protocols" and then make that new code from 125830 extract the correct translation from the json.
> 
> Alex Richardson wrote:
>     Reading the translated string can be done using `KPluginMetaData::readTranslatedString()`
> 
> Christoph Cullmann wrote:
>     Hmm, Ok, can take a look at that scripts. Will it be a problem that the ExtraNames are a stringlist or is that fine?
> 
> Albert Astals Cid wrote:
>     You'll have to take care of serializing and unserializing the list, ideally using a well known marker like ; or similar. The scripts are at https://websvn.kde.org/trunk/l10n-kf5/scripts/
> 
> Christoph Cullmann wrote:
>     Hi, ok, started to take a look at that again ;=) Is there actually any way to get all entries out of KConfig for all locales in the .ini? Atm I struggle a bit with the fact that the localized keys are hidden from any keys() accessor I can get from the outside.

+1 on having an application for this diff to be applied.  I abandoned my own diff that did nearly the same thing. https://git.reviewboard.kde.org/r/126038/


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87966
-----------------------------------------------------------


On Nov. 1, 2015, 6:13 p.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2015, 6:13 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -----
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> -------
> 
> Tests still work (one needed patching, as the exec line contains now the full path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151208/6620848f/attachment.html>