Review Request 126185: Make the KAppTemplate CMake module global

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126185/#review89242
-----------------------------------------------------------



kde-modules/KDETemplateMacro.cmake (line 1)
<https://git.reviewboard.kde.org/r/126185/#comment61041>

    Use function instead of macro: this prevents variables leaking accidentally. That will also allow removing the leading underscores on the variable names.



kde-modules/KDETemplateMacro.cmake (line 2)
<https://git.reviewboard.kde.org/r/126185/#comment61043>

    You might want to consider using keyword arguments (ie: cmake_parse_arguments). This makes the function more extensible in the future.



kde-modules/KDETemplateMacro.cmake (lines 32 - 42)
<https://git.reviewboard.kde.org/r/126185/#comment61044>

    Have a look at CMake's tar mode - run `cmake -E` and look at the tar command. This will mean the command won't depend on external utilities like 7-zip.



kde-modules/KDETemplateMacro.cmake (line 45)
<https://git.reviewboard.kde.org/r/126185/#comment61045>

    To make this slightly more general, consider passing in the install destination as an argument, or at least allowing that as a possibility. The actual directory could (should?) be put into KDEInstallDirs.cmake as an extra variable.


- Alex Merry


On Dec. 3, 2015, 12:34 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126185/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2015, 12:34 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Simon Wächter.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> templates are very useful as teaching tool in order to make
> a minimal application that uses a certain framework.
> templates in the KAppTemplate repository will always get forgotten
> (plus kapptemplate is not really necessary as they work in kdevelop as well)
> An ideal situation would be frameworks having templates in their own repos
> with templates of barebone apps using the main framework features.
> In order to do that, the cmake stuff needed in order to correctly install
> a template needs to be ported to a place avaiable to all frameworks
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDETemplateMacro.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126185/diff/
> 
> 
> Testing
> -------
> 
> done some templates installed by plasma-framework
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151208/8c9208bc/attachment-0001.html>