Review Request 126212: Do not crash if KDE platform integration is loaded but SNI is unavailable
Martin Klapetek
martin.klapetek at gmail.com
Mon Dec 7 17:23:53 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126212/#review89225
-----------------------------------------------------------
Ship it!
Ship It!
- Martin Klapetek
On Dec. 1, 2015, 1:53 a.m., Sven Brauch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126212/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2015, 1:53 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Bugs: 350785
> https://bugs.kde.org/show_bug.cgi?id=350785
>
>
> Repository: knotifications
>
>
> Description
> -------
>
> See bug 350785. The crash is quite nasty, makes dbus allocate all available file descriptors plus hangs the application; worth preventing imo. Yes, the setup leading to this issue is broken, but it's just an env var and it's hard to track down.
>
>
> Diffs
> -----
>
> src/kstatusnotifieritem.cpp c48f4d0
>
> Diff: https://git.reviewboard.kde.org/r/126212/diff/
>
>
> Testing
> -------
>
> Now prints an error message instead of crashing.
>
>
> Thanks,
>
> Sven Brauch
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151207/801615e6/attachment.html>
More information about the Kde-frameworks-devel
mailing list