Review Request 125800: OS X build and warning fix

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125800/#review89165
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Oct. 27, 2015, 11:01 p.m., Samuel Gaist wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125800/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2015, 11:01 p.m.)
> 
> 
> Review request for KDE Frameworks and Ivan Romanov.
> 
> 
> Repository: qca
> 
> 
> Description
> -------
> 
> The cmake find file was missing, but CoreFoundation being a system
> framework, no need to search for it.
> 
> OS X: Update code to not use deprecated functions/data structure
> 
> CSSM_DATA and SecCertificateGetData have been deprecated since 10.7.
> This patch uses SecCertificateCopyData which is the official
> replacement.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt dbce08272deb284f3cb0fd09ccfec4ab93ce3e23 
>   src/CMakeLists.txt a60bda0bf3d8bad7523ee7d50798c8cdb6c2eccb 
>   src/qca_systemstore_mac.cpp 9349c90c8258d3d1f00a3796d93f94c09f5b1f2a 
> 
> Diff: https://git.reviewboard.kde.org/r/125800/diff/
> 
> 
> Testing
> -------
> 
> Build on OS X 10.8
> 
> Check that qcatool-qt5 keystore list-stores returns the same results
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151206/5b12ede9/attachment.html>