Review Request 126231: Fix a small artifact of kratingwidget on hidpi

Christoph Feck cfeck at kde.org
Sat Dec 5 13:47:20 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126231/#review89145
-----------------------------------------------------------

Ship it!


Ship It!

- Christoph Feck


On Dec. 3, 2015, 8:37 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126231/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2015, 8:37 a.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck and David Edmundson.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> The other half of star size is wrong when calling drawPixmap. This change makes the size arguments same as other drawPixmap calls.
> 
> 
> Diffs
> -----
> 
>   src/kratingpainter.cpp 1a4378a 
> 
> Diff: https://git.reviewboard.kde.org/r/126231/diff/
> 
> 
> Testing
> -------
> 
> To reproduce the problem, try to set rating to 5 / 10 and make hover rating to be 6.
> Now it draws correctly.
> 
> 
> File Attachments
> ----------------
> 
> Demonstrate the problem
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/12/03/5fd4f10d-cc2a-49f4-b6b1-ac5ac1d1e9e5__screenshot24.png
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151205/dd2cf06a/attachment.html>


More information about the Kde-frameworks-devel mailing list