Review Request 126242: KCoreAddons: Add WheelArea

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126242/#review89126
-----------------------------------------------------------


Maybe it fits better in KQuickControls? KCoreAddons is mostly for actually interfacing with KCoreAddons the framework.

Have you considered getting an iteration of this upstream in Qt? At first glance the feature doesn't look super-useful though... ^^'

- Aleix Pol Gonzalez


On Dec. 4, 2015, 3:21 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126242/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 3:21 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Our QML code in various places is using custom handling for wheel events with high resolution touchpads, but this code varies in details (eg. doesn't reset wheelDelta on changing direction or using completely different logic).
> This adds a WheelArea that takes care of computing delta in consistent manner and offers signals for scroll steps (up, down, left, right).
> 
> This code is a merge of wheel handling code from batteryapplet and plasma-pa + it adds handling of scrolling to both directions.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kcoreaddons/qmldir 626f8ce 
>   src/qmlcontrols/kcoreaddons/CMakeLists.txt 3f77f2d 
>   src/qmlcontrols/kcoreaddons/WheelArea.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126242/diff/
> 
> 
> Testing
> -------
> 
> Works fine with both classic mouse wheel scrolling and high resolution scrolling (from trackpoint).
> 
> I'm not sure if KCoreAddons is the correct place.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151204/4df4e971/attachment.html>