Review Request 126222: Fix rating widget flickering when selecting rating with mouse

[Xuetian Weng]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126222/
-----------------------------------------------------------

(Updated Dec. 3, 2015, 10:19 a.m.)


Review request for KDE Frameworks, David Faure and Lamarque Souza.


Changes
-------

add an extra check to avoid rating to be set to -1.


Repository: kwidgetsaddons


Description
-------

Refactor the rating calculation:
1. Disable feature introduced in bug 171343 when halfSteps is enabled.
2. Merge the two pieces of code, and try to make it clearer and simpler.
3. make hover 0 star also show visual effect.


Diffs (updated)
-----

  src/kratingpainter.cpp 1a4378a 
  src/kratingwidget.cpp d0d2903 

Diff: https://git.reviewboard.kde.org/r/126222/diff/


Testing
-------

Current rating is 0, hover on the 1st star, 1 star lights up, click on 1st star, rating becomes 2.

Current rating is 2. hover on the 1st star, half star lights up, click on 1st star, rating becomes 1.

Current rating is 1/2. move mouse to the left most edge, star's color becomes lighter. Click and rating becomes 0.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151203/72543055/attachment.html>