Review Request 126226: kdetemplate_add_app_templates installs previews

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126226/#review89081
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Dec. 3, 2015, 1:27 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126226/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2015, 1:27 a.m.)
> 
> 
> Review request for KDE Frameworks and Marco Martin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> kapptemplate can't deal with templats without previews, so make sure we install the preview image.
> 
> Without this patch, the installed templates show up broken in kapptemplate. With it, they work as expected.
> 
> I'm assuming here that the preview has the baseName + .png, otherwise we'd have to read Icon field from the .kdevtemplate file, but that seems way too much hassle. The error message resulting from a wrong file name will show the expected filename, so it doesn't exactly hide the error.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDETemplateMacro.cmake 796c3f1 
> 
> Diff: https://git.reviewboard.kde.org/r/126226/diff/
> 
> 
> Testing
> -------
> 
> Installed templates/ from plasma-framework, this patch makes them work in kapptemplate.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151203/9399d2aa/attachment.html>