Review Request 126222: Fix rating widget flickering when selecting rating with mouse

[Lamarque Souza]

> On Dec. 2, 2015, 4:45 p.m., Lamarque Souza wrote:
> > That code was added to fix this bug https://bugs.kde.org/show_bug.cgi?id=171343#c6
> 
> Xuetian Weng wrote:
>     Emm.. interesting feature. But code inside mouseMoveEvent looks fishy, and this feature shouldn't be used when halfStepsEnabled is true. I'll try to keep this feature then.

There is no change in the diff between revisions 1 and 2. Could you update the diff again?


- Lamarque


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126222/#review89052
-----------------------------------------------------------


On Dec. 2, 2015, 11:37 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126222/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 11:37 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Lamarque Souza.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> Refactor the rating calculation:
> 1. Disable feature introduced in bug 171343 when halfSteps is enabled.
> 2. Merge the two pieces of code, and try to make it clearer and simpler.
> 3. make hover 0 star also show visual effect.
> 
> 
> Diffs
> -----
> 
>   src/kratingwidget.cpp d0d2903 
> 
> Diff: https://git.reviewboard.kde.org/r/126222/diff/
> 
> 
> Testing
> -------
> 
> Current rating is 0, hover on the 1st star, 1 star lights up, click on 1st star, rating becomes 2.
> 
> Current rating is 2. hover on the 1st star, half star lights up, click on 1st star, rating becomes 1.
> 
> Current rating is 1/2. move mouse to the left most edge, star's color becomes lighter. Click and rating becomes 0.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151203/848b957f/attachment.html>