Purpose as a KDE Framework

[David Edmundson]

AlternativesModel doesn't seem like a good name. Alternate to what?

---------

/** @returns the job that will perform the share of the specified @p data.*/

what data?

------

Does the JSON blob in Job::setData() match the X-Purpose-OutboundArguments
of that plugin?

I don't seem to be able to access what those args are from C++ like
Configuration::neededArguments

Why JSON here rather than QVariantMap? It's all internal to C++ API.

---------

In the pastebin plugin why are you registering the KJob with the job
tracker?

You're returning the progress via the kjob the plugin gives back, and the
relevant UI should do it.

--------

import Ubuntu.OnlineAccounts 0.1 as OA

Can we depend on that? Seems weird.

Definitely needs mentioning in CMake

--------

saveas/saveasplugin.json

probably best to avoid swearing in a release.

--------

That ktp plugin is fine for a demo of things, but it is not release
material.

The job will return that you've shared things even if you click cancel,
also you say it will return a URL in the json blob and it doesn't.

-----

There's a comment

     * This shouldn't require to have the job actually running on the same
process as the app.

I don't get what that means.

​
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151201/056cb495/attachment.html>