Review Request 126212: Do not crash if KDE platform integration is loaded but SNI is unavailable
Sven Brauch
mail at svenbrauch.de
Tue Dec 1 00:37:02 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126212/
-----------------------------------------------------------
(Updated Dec. 1, 2015, 12:37 a.m.)
Review request for KDE Frameworks.
Changes
-------
... and of course it was wrong in the diff as well, sorry again
Repository: knotifications
Description
-------
See bug 350785. The crash is quite nasty, makes dbus allocate all available file descriptors plus hangs the application; worth preventing imo. Yes, the setup leading to this issue is broken, but it's just an env var and it's hard to track down.
Diffs (updated)
-----
src/kstatusnotifieritem.cpp c48f4d0
Diff: https://git.reviewboard.kde.org/r/126212/diff/
Testing
-------
Now prints an error message instead of crashing.
Thanks,
Sven Brauch
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151201/f9c6f25a/attachment.html>
More information about the Kde-frameworks-devel
mailing list