Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

[David Faure]

> On Aug. 30, 2015, 2:07 p.m., Vishesh Handa wrote:
> > src/sycoca/ksycoca.cpp, line 644
> > <https://git.reviewboard.kde.org/r/124876/diff/1/?file=397207#file397207line644>
> >
> >     Does the added `(void)` disable some kind of warning?

Yes it's the standard way of expressing "I'm discarding the return value here, but that's OK, I don't need it."


> On Aug. 30, 2015, 2:07 p.m., Vishesh Handa wrote:
> > src/sycoca/ksycoca.cpp, line 662
> > <https://git.reviewboard.kde.org/r/124876/diff/1/?file=397207#file397207line662>
> >
> >     random thought: Is the return value given by kbuildsyscoca useful?

The process exit code? kbuildsycoca is not supposed to fail, but if it does we'll notice because there's no ksycoca file. Well, or maybe there was one and it's now outdated, but what else can we do than use it...


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124876/#review84583
-----------------------------------------------------------


On Aug. 28, 2015, 9:41 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124876/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 9:41 a.m.)
> 
> 
> Review request for KDE Frameworks, Boudewijn Rempt and Vishesh Handa.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> If 1.5s have passed since the last time we checked, we compare the mtime of
> the directories (12 dirs on my system) with the timestamp stored in the
> ksycoca database (which indicates that all changes prior to that time
> are in the DB).
> 
> Note that we only check the mtime of dirs, not files. Therefore manually
> editing an installed .desktop file will require touching the dir, or
> running kbuildsycoca5.
> 
> 
> Diffs
> -----
> 
>   src/sycoca/ksycoca.cpp b7f7abc88db90d784851d91036069e0647fdcbf6 
>   src/sycoca/ksycoca_p.h 9f403d6f4be2b406f4985f668176cfa56a5898ea 
> 
> Diff: https://git.reviewboard.kde.org/r/124876/diff/
> 
> 
> Testing
> -------
> 
> the kservice unittests still pass
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150830/8fc8d4bf/attachment.html>