Review Request 124963: New widget: KNewPasswordWidget

[Lamarque Souza]

> On Aug. 28, 2015, 11:30 a.m., Lamarque Souza wrote:
> > src/knewpasswordwidget.cpp, line 92
> > <https://git.reviewboard.kde.org/r/124963/diff/1/?file=399453#file399453line92>
> >
> >     Is there any documentation explaining this calculation?
> 
> Elvis Angelaccio wrote:
>     I don't know, sorry. The whole strength calculator code is just taken from KNewPasswordDialog. I don't even know its original author (git blame does not help here).

If it is not your code then you are not required to document it.


> On Aug. 28, 2015, 11:30 a.m., Lamarque Souza wrote:
> > src/knewpasswordwidget.cpp, line 154
> > <https://git.reviewboard.kde.org/r/124963/diff/1/?file=399453#file399453line154>
> >
> >     Please write a short explanation of what is happening here. By what I could understand you are calculating the number of characters with different categories in the password, am I correct?
> 
> Elvis Angelaccio wrote:
>     As above, not my code :(
>     If this is a blocker, I can look for a different and documented algorithm and replace the current one.

No need to replace it. I wish it would have been documented from the begining :-/


- Lamarque


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124963/#review84525
-----------------------------------------------------------


On Aug. 28, 2015, 1:56 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124963/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 1:56 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> This widget is a stripped-down version of KNewPasswordDialog, without any dialog-specific stuff.
> 
> ### Why a new widget?
> 
> This widget is meant to be easily embedded in any custom password dialog, including KNewPasswordDialog. It's the least common denominator of features that any password dialog should offer to the user.
> 
> ### Features
> 
> * Password visibility action (same as RR 124698). The password verification field is hidden if the user shows the password.
> * Background warning colour. The password verification field gets a coloured background whenever the password and its verification don't match. (feature borrowed from Keepass)
> * Password status signal. This allows the upper level dialogs to update their stuff (enable/disable OK button, show warnings for low password strength, etc.)
> * Password strength bar can be hidden.
> * Unit test.
> 
> ### Use cases
> At least the following:
> 
> * Ark (new archive dialog)
> * KNewPasswordDialog refactoring (my next RR if this one gets accepted)
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt ac708ef33e3be89db85d43911f96e536c52f741d 
>   autotests/knewpasswordwidgettest.h PRE-CREATION 
>   autotests/knewpasswordwidgettest.cpp PRE-CREATION 
>   src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
>   src/knewpasswordwidget.h PRE-CREATION 
>   src/knewpasswordwidget.cpp PRE-CREATION 
>   src/knewpasswordwidget.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124963/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> knewpasswordwidget1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/28/5796469c-28b7-4151-b9cb-6a327631db75__knewpasswordwidget1.png
> knewpasswordwidget2.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/28/b3bfc9ac-ab8e-404c-8091-b5ad9e3e054f__knewpasswordwidget2.png
> knewpasswordwidget3.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/28/dfaeea4e-65da-4961-b266-986a21f54ca7__knewpasswordwidget3.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150828/17ef6eaf/attachment.html>