Review Request 124698: KPasswordDialog: allow the user to show the password

[Christoph Feck]

> On Aug. 27, 2015, 9:35 p.m., David Faure wrote:
> > Ship It!

Does it make sense to also have this feature in KNewPasswordDialog?


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124698/#review84491
-----------------------------------------------------------


On Aug. 26, 2015, 10:36 a.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124698/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 10:36 a.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Bugs: 224686
>     https://bugs.kde.org/show_bug.cgi?id=224686
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> Starting from Qt 5.2, adding a trailing QAction to a QLineEdit is fairly trivial. This patch implements such an action in order to allow a user to show the password being typed. The action is only available if no password is given to the dialog as preset.
> 
> About the icon: for now I've used `games-hint` from Breeze. Let me know whether there is a more relevant icon already available. If not, we can either request it or create a symlink for this one, e.g. `password-hint` or similar.
> 
> About the last screenshot: the greyed icon is due to Qt bug [39660](https://bugreports.qt.io/browse/QTBUG-39660). Once fixed upstream (Qt 5.5?), the action will be properly hidden and there will be no icon greyed out.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 1e664453623b4a03c07b9a478b2ca7e240cb949f 
>   src/icons.qrc PRE-CREATION 
>   src/icons/hint.svg PRE-CREATION 
>   src/icons/visibility.svg PRE-CREATION 
>   src/kpassworddialog.h 9de2724640f483d5ab1134510fb84e1245814d90 
>   src/kpassworddialog.cpp 3d348964b4c44d26c44856fc08c199007a195aca 
> 
> Diff: https://git.reviewboard.kde.org/r/124698/diff/
> 
> 
> Testing
> -------
> 
> * Create a default KPasswordDialog. The new action is shown as soon as a password is being typed. The action is no more available as soon as the line edit is cleared.
> * Create a default KPasswordDialog, call `setPassword()` with a non-empty password and then show the dialog. The action is not available.
> 
> 
> File Attachments
> ----------------
> 
> kpassworddialog1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/e5333571-d38f-48bb-9b86-4e9ceb1a540b__kpassworddialog1.png
> kpassworddialog2.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/61f321e9-b940-49ad-bc49-1ef136bb758a__kpassworddialog2.png
> kpassworddialog3.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/6b66c26b-09ba-4f9b-852d-69271ffd46cd__kpassworddialog3.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150827/9e1ee2eb/attachment-0001.html>