Review Request 124941: Reparse notification config only when actually needed

Martin Klapetek martin.klapetek at gmail.com
Wed Aug 26 22:08:22 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124941/
-----------------------------------------------------------

(Updated Aug. 27, 2015, 12:08 a.m.)


Review request for KDE Frameworks.


Changes
-------

Fix Kai's points


Repository: knotifications


Description
-------

Till now every KNotification::notify() call would reparse the whole cache of configs. With this patch it watches for KNotifyConfig changes and reparses only those configs that had actually changed.


Diffs (updated)
-----

  src/knotificationmanager.cpp 4c648a9 
  src/knotificationmanager_p.h 95e13d1 
  src/knotifyconfig.h fae17cb 
  src/knotifyconfig.cpp 6a46a00 

Diff: https://git.reviewboard.kde.org/r/124941/diff/


Testing
-------

Works as expected.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150826/cb124956/attachment.html>


More information about the Kde-frameworks-devel mailing list