Review Request 124878: Cache a KEmoticons instance here, not a KEmoticonsTheme.

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124878/
-----------------------------------------------------------

(Updated Aug. 26, 2015, 4:11 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 977afe65ac657f19795effae24059ac298cfe16a by Volker Krause to branch master.


Repository: kemoticons


Description
-------

This already contains a cache for the theme, and it is expensive to create
itself. Cuts down the cost in half here.

Still not perfect though, the currentThemeName() call in theme() parses
kdeglobals every time. And this is called per line for KMail's message
rendering, resulting in more than 15% of the instructions spend in KConfig
parsing code.


Diffs
-----

  src/integrationplugin/ktexttohtml.cpp 604c18eed06ed76b13aa644fa762a1de6d2f3961 

Diff: https://git.reviewboard.kde.org/r/124878/diff/


Testing
-------

Callgrind + KMail.


Thanks,

Volker Krause

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150826/cca492ad/attachment.html>