Review Request 124698: KPasswordDialog: allow the user to show the password

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124698/#review84390
-----------------------------------------------------------


Very cool. But let's wait for Plasma 5.5 to be released then? Don't really want to get an "unknown" icon in front of users there...

The alternative would be to put the icons in a qrc file as part of the framework. This would actually be good for non-plasma users (e.g. Windows, OSX etc.) running a single app that uses kwidgetsaddons. But then the icon is not themeable anymore. I guess this would be a good use case for
QIcon::fromTheme("iconname", QIcon("qrc:/<fallback_from_resource>")), actually.

- David Faure


On Aug. 25, 2015, 7:15 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124698/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2015, 7:15 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Bugs: 224686
>     https://bugs.kde.org/show_bug.cgi?id=224686
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> Starting from Qt 5.2, adding a trailing QAction to a QLineEdit is fairly trivial. This patch implements such an action in order to allow a user to show the password being typed. The action is only available if no password is given to the dialog as preset.
> 
> About the icon: for now I've used `games-hint` from Breeze. Let me know whether there is a more relevant icon already available. If not, we can either request it or create a symlink for this one, e.g. `password-hint` or similar.
> 
> About the last screenshot: the greyed icon is due to Qt bug [39660](https://bugreports.qt.io/browse/QTBUG-39660). Once fixed upstream (Qt 5.5?), the action will be properly hidden and there will be no icon greyed out.
> 
> 
> Diffs
> -----
> 
>   src/kpassworddialog.h 9de2724640f483d5ab1134510fb84e1245814d90 
>   src/kpassworddialog.cpp 3d348964b4c44d26c44856fc08c199007a195aca 
> 
> Diff: https://git.reviewboard.kde.org/r/124698/diff/
> 
> 
> Testing
> -------
> 
> * Create a default KPasswordDialog. The new action is shown as soon as a password is being typed. The action is no more available as soon as the line edit is cleared.
> * Create a default KPasswordDialog, call `setPassword()` with a non-empty password and then show the dialog. The action is not available.
> 
> 
> File Attachments
> ----------------
> 
> kpassworddialog1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/776c6bfe-8fa1-4362-b26a-e7860bbfb19f__kpassworddialog1.png
> kpassworddialog2.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/ee6fff91-bc7b-41c6-afba-992902cf1157__kpassworddialog2.png
> kpassworddialog3.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/c4298080-4b02-48f5-8e8a-af35819652d3__kpassworddialog3.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150826/43a7a1f3/attachment-0001.html>