Review Request 124905: Win: Hide console window for binaries in LIBEXEC

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124905/#review84389
-----------------------------------------------------------


It sounds to me like ecm_mark_non_gui_executable doesn't do the right thing then, and should be fixed, instead?

These are non gui executables, so from an "API" point of view, using this function is correct.

Would we ever want a console window when running an app on windows? I guess not?
So maybe we should do whatever "WIN32" does from within that function, if it's doable outside the add_executable call?

- David Faure


On Aug. 24, 2015, 1:36 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124905/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2015, 1:36 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Boudewijn Rempt.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Win: Hide console window for binaries in LIBEXEC
> 
> 
> Diffs
> -----
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e2800b84c312431cc1996ac81d1ef6fb5cfc 
>   src/ioslaves/http/kcookiejar/CMakeLists.txt 7b4778d1f67c1ad9f9edcaa4692b39ee6fe3f365 
>   src/kioexec/CMakeLists.txt 91284a3a61b86770b4d1939da52d256840803608 
>   src/kioslave/CMakeLists.txt e02febd380b268c596e8ecc3b745b6f50993ab4e 
>   src/kpac/CMakeLists.txt fc5989714480ca49b5bd72e1c7b458b26bd0d9bc 
> 
> Diff: https://git.reviewboard.kde.org/r/124905/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150826/cff3993f/attachment.html>