Review Request 124884: Fix KSwitchLangaugeDialog
Albert Astals Cid
aacid at kde.org
Mon Aug 24 22:10:14 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124884/
-----------------------------------------------------------
(Updated Aug. 24, 2015, 10:10 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Changes
-------
Submitted with commit bede4e5440c04f4c690a76967ebd755d321ef5b1 by Albert Astals Cid to branch master.
Repository: kxmlgui
Description
-------
QLocale and us don't always agree on how to call things, for example we call our translation "ca" while QLocale gives us "ca_ES" in locale::name so we need to strip the _ in some cases.
To make things funnier, QLocale::uiLanguages actually returns ca-ES so we first turn all the - to _
Diffs
-----
src/kswitchlanguagedialog_p.cpp 2ae4b0b
Diff: https://git.reviewboard.kde.org/r/124884/diff/
Testing
-------
tested rsibreak, works + See screenshots
File Attachments
----------------
Before
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/22/79c70322-b55d-4940-a167-b98309eaa6ec__before.png
After
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/22/f3eae50b-53a1-4836-809d-ede574c80690__after.png
Thanks,
Albert Astals Cid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150824/6d78b30e/attachment.html>
More information about the Kde-frameworks-devel
mailing list