Review Request 124872: Default to Breeze colors

[Jeremy Whiting]

> On Aug. 24, 2015, 12:13 a.m., Martin Gräßlin wrote:
> > I must say I'm rather shocked at how this is implemented. Would it be possible to move the defaults into our QPT plugin, so that these defaults are only applied if running on a platform with our plugin, otherwise it picks Qt defaults?

IMO it would also probably be good if we had some way of making the default based on the actual color scheme rather than having it have a copy of all the colors from the scheme. That way if Breeze.colors ever changes we don't either a) need to update this also or b) get mismatch between Default and Breeze in the colors kcm ui.


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124872/#review84241
-----------------------------------------------------------


On Aug. 21, 2015, 3:35 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124872/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2015, 3:35 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and KDE Usability.
> 
> 
> Bugs: 351530
>     https://bugs.kde.org/show_bug.cgi?id=351530
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> This makes KColorScheme return Breeze colors by default, ie. choosing "Default" in Colors KCM is no longer Oxygen.
> 
> 
> Diffs
> -----
> 
>   src/kcolorscheme.cpp f1ec1e3 
> 
> Diff: https://git.reviewboard.kde.org/r/124872/diff/
> 
> 
> Testing
> -------
> 
> Seems to look right, typos reserved :)
> 
> Only thing missing now is the window decoration which is set in the WM section of kdeglobals by the breeze.colors but KWin defaults to highlight colors, so it stays blue.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150824/449bbeb0/attachment.html>