Review Request 124879: Optimization readEntryGui

Albert Astals Cid aacid at kde.org
Sat Aug 22 17:05:20 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124879/#review84189
-----------------------------------------------------------


While you're at it move formatError down to the only place it is used?

- Albert Astals Cid


On ago. 22, 2015, 3:06 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124879/
> -----------------------------------------------------------
> 
> (Updated ago. 22, 2015, 3:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Don't attempt to build error string in any case
> 
> 
> Diffs
> -----
> 
>   src/gui/kconfiggroupgui.cpp e2eb950fb93d40abec0988c9af58c1ae14cb2011 
> 
> Diff: https://git.reviewboard.kde.org/r/124879/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150822/aaff447b/attachment.html>


More information about the Kde-frameworks-devel mailing list