Review Request 124856: Be a bit stubborn calling newInstance

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124856/
-----------------------------------------------------------

(Updated ago. 21, 2015, 4:04 p.m.)


Review request for KDE Frameworks and Thiago Macieira.


Changes
-------

Less heavy way of making it work


Repository: kdelibs4support


Description
-------

We're calling newInstance from the parent but the child may have not gotten to the point where the application object has been created so the call may fail.

I don't know why this did not manifest before using Thiago's Qt dbus threading patches but seems the code was racy anyway, should not hurt to have this for Qt's without those patches.


Diffs (updated)
-----

  src/kdeui/kuniqueapplication.cpp 713c6f4 
  src/kdeui/kuniqueapplication_p.h de4b328 

Diff: https://git.reviewboard.kde.org/r/124856/diff/


Testing
-------

konsole starts fine with this + Thiago's Qt dbus threading patches


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150821/edd6c0b9/attachment.html>