Review Request 124821: karchive: Fix krazy2 warnings (foreach usage)

[Boris Egorov]

> On Aug. 19, 2015, 7:41 p.m., Albert Astals Cid wrote:
> > I meant all the explicit, not only this one, by declaring it explicit we are changing the source compatibility, personally i'd reduce the patch to just the foreach const &
> 
> Boris Egorov wrote:
>     Ah, I see. So these warnings about explicit ctors are useless for libraries most of the time..
> 
> Albert Astals Cid wrote:
>     No, they are not, they apply, they should have just been fixed before the release or should be fixed after we decide to break source compatibility (KF6?)

I see. Thanks for the explanation.


- Boris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124821/#review84068
-----------------------------------------------------------


On Aug. 20, 2015, 3:17 a.m., Boris Egorov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124821/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2015, 3:17 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: karchive
> 
> 
> Description
> -------
> 
> Fix krazy2 warnings (foreach usage)
> 
> 
> Diffs
> -----
> 
>   src/k7zip.cpp bdb2e5a 
> 
> Diff: https://git.reviewboard.kde.org/r/124821/diff/
> 
> 
> Testing
> -------
> 
> Build karchive, ktexteditor, kio.
> 
> 
> Thanks,
> 
> Boris Egorov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150821/fd744d20/attachment.html>