Review Request 124821: karchive: Fix krazy2 warnings (explicit ctors, foreach)
Albert Astals Cid
aacid at kde.org
Wed Aug 19 19:41:57 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124821/#review84068
-----------------------------------------------------------
I meant all the explicit, not only this one, by declaring it explicit we are changing the source compatibility, personally i'd reduce the patch to just the foreach const &
- Albert Astals Cid
On ago. 19, 2015, 3:51 p.m., Boris Egorov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124821/
> -----------------------------------------------------------
>
> (Updated ago. 19, 2015, 3:51 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: karchive
>
>
> Description
> -------
>
> Fix krazy2 warnings (explicit ctors, foreach)
>
>
> Diffs
> -----
>
> src/k7zip.cpp bdb2e5a
> src/kar.h 85bd650
> src/karchive.h b528a4a
> src/krcc.h 18c7d00
> src/kzip.h 84156c7
>
> Diff: https://git.reviewboard.kde.org/r/124821/diff/
>
>
> Testing
> -------
>
> Build karchive, ktexteditor, kio.
>
>
> Thanks,
>
> Boris Egorov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150819/8c975845/attachment.html>
More information about the Kde-frameworks-devel
mailing list