Review Request 124795: Provide deterministic sort order for KDirSortFilterProxyModelPrivate::compare

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124795/#review83964
-----------------------------------------------------------

Ship it!


Good solution!

Clearly kmail's folder tree needs the same kind of fix, I see "spam" and "Spam" swapping places regularly...

- David Faure


On Aug. 17, 2015, 5:46 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124795/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2015, 5:46 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> We already provide a deterministic sort order for KDirSortFilterProxyModelPrivate::compare when not using the QCollator, but when using it we don't. This piggy-backs on the existing code to fix that.
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/kdirsortfilterproxymodel.cpp 22ac025 
> 
> Diff: https://git.reviewboard.kde.org/r/124795/diff/
> 
> 
> Testing
> -------
> 
> The open dialog doesn't switch like crazy now when hovering between two folders with the same name and different case.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150817/a9762a92/attachment.html>