Review Request 124789: Respect -DBUILD_TESTING=OFF

[Alex Merry]

> On Aug. 17, 2015, 3:51 p.m., David Rosca wrote:
> > Thanks. I will commit it for you.
> 
> David Rosca wrote:
>     But I need your full name.
> 
> Armin K. wrote:
>     I've used Armin K. all the time I've been online and nobody has complained when using it in git commits. I don't feel comfortable in revealing my last name. krejzi is but an alias, not a last name.

I don't think that will be an issue. If "Armin K" is the name you commonly use online, that should be enough.

We strongly encourage people to use their "real name", whatever that means, but that doesn't mean it needs to be exactly what is on their government-issued documentation or whatever. For example, I have three variants of my name in common use, and the one you see attached to this message is not the variant on my passport (although it is similar). I think the main things are that it should be a name you are attached to in terms of reputation (to encourage you to take responsibility for what you do) and it should be a name you are unlikely to regret using in 10 years (so no FluffyBunny47).


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124789/#review83950
-----------------------------------------------------------


On Aug. 17, 2015, 1:57 p.m., Armin K. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124789/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2015, 1:57 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: bluez-qt
> 
> 
> Description
> -------
> 
> Other frameworks don't uncoditionally enable building of testing executables.
> 
> Note that I don't have commit access, and if this change gets accepted, I ask that someone commits it.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt feb2276 
> 
> Diff: https://git.reviewboard.kde.org/r/124789/diff/
> 
> 
> Testing
> -------
> 
> I have verified that no files in tests and autotests subdir were built when -DBUILD_TESTING=OFF was passed to cmake.
> Everything was built when the mentioned build option wasn't used.
> 
> 
> Thanks,
> 
> Armin K.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150817/4588cb1f/attachment.html>