Review Request 124772: kservice: fix almost all clang warnings

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124772/#review83945
-----------------------------------------------------------

Ship it!


+1


src/services/kservicegroup.cpp (line 711)
<https://git.reviewboard.kde.org/r/124772/#comment58146>

    QStringLiteral


- Milian Wolff


On Aug. 16, 2015, 12:39 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124772/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2015, 12:39 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> except in lex/yacc generated code, some -Wmissing-prototypes cases (including in Qt macros),
> moc calling deprecated methods, and two if(false) in substring support (for which I emailed aseigo).
> 
> My flags:
> -Weverything -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-exit-time-destructors -Wno-padded -Wno-sign-conversion -Wno-documentation -Wno-undefined-reinterpret-cast -Wno-shorten-64-to-32 -Wno-conversion -Wno-gnu-zero-variadic-macro-arguments -Wno-global-constructors -Wno-shadow -Werror=format-security -Werror=return-type -Wno-variadic-macros -Wmissing-include-dirs -Wno-used-but-marked-unused -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -pedantic -std=c++0x -fdeprecated-macro -fdebug-compilation-dir
> 
> 
> Diffs
> -----
> 
>   src/services/kautostart.cpp d140aabd42f9f0e3c1fd50d559209347b5d5134e 
>   src/kbuildsycoca/vfolder_menu.cpp 2b3aa5c7e8eda40c4ef14295e045966b50bfc5c0 
>   src/kbuildsycoca/ksycocaresourcelist.h bcc4efa1ef3d98b4e34f69bf027df10616a1c696 
>   autotests/kautostarttest.cpp 233fbe26abc1ec252605ca3ed8c3270dd3ab375f 
>   autotests/kmimeassociationstest.cpp 74c85c696e71caedf6c4c488d052fda26cc9cd61 
>   autotests/kservicetest.cpp 00940f8b4ca01d4cbc2fe3db2172b1efe4d6ef69 
>   autotests/ksycocadicttest.cpp 69e338869a533e653a49bddbf1eab76505c1c14a 
>   src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 
>   src/kbuildsycoca/kbuildmimetypefactory.cpp c2856882b80c8e5c52d5893e72da060195ab1d48 
>   src/kbuildsycoca/kbuildservicefactory.cpp ea76374e421f274b1d8fc4d5e49002689e424894 
>   src/kbuildsycoca/kbuildservicegroupfactory.cpp 199b6c4b0c20e99d3212a31b7a50e53d5f028028 
>   src/kbuildsycoca/kbuildservicetypefactory.cpp 40c4758041bb53abba8d7ab1c2fdc1d426890fa6 
>   src/kbuildsycoca/kbuildsycoca.cpp 3ab77c4c93537be49810149185af72d57060aa4d 
>   src/kbuildsycoca/kbuildsycocainterface.h fcf891007e34e51a8bbfea95a138aa822dd1a8d8 
>   src/kbuildsycoca/kctimefactory.cpp ceccdf29892214f5f347fc3377454f4529ba4ab0 
>   src/services/kmimetypefactory.cpp 0cd81d4e2157f5a96e86df56b325d87bda810da5 
>   src/services/kmimetypefactory_p.h ae399d86d9d4083242812f55b7cb8064a9fbe7f9 
>   src/services/kservice.cpp c4a96e1aadb955d036b06fce5c36ac41cb3d6bbd 
>   src/services/kservicefactory.cpp f5e4412955a7c0ff455defcb49f9fb918a4617c7 
>   src/services/kservicegroup.cpp b182b5a87cedf62797889805c7f2ee9e05363361 
>   src/services/kservicegroup_p.h 1f8f8bd3cfbc18e572ec91992105e7c633c9b8d4 
>   src/services/kservicegroupfactory.cpp 8ddac31342bda7a0c022aa46c3a0ffd57c746b74 
>   src/services/kservicetype.cpp d881371c76bca78df9cbe4cf793a9928c3a29a23 
>   src/services/kservicetypefactory.cpp 7eab5e6a4020e88dcfa43ab4eae325895fd3a289 
>   src/services/ktraderparse.cpp 670b79342a81be3cd6461b9b510d842375574fc3 
>   src/services/ktraderparsetree.cpp bef271d06109a6701f34ee32bdd724cdadbb51b1 
>   src/services/ktraderparsetree_p.h 9b914fd45e24b5acec206e9708b643a8b1883b51 
>   src/sycoca/ksycoca.cpp da21b9ee83fe45fc3f31400f86bcd9fbbd7d850e 
>   src/sycoca/ksycocadevices.cpp PRE-CREATION 
>   src/sycoca/ksycocadevices_p.h 195b24cc99282debb1640e7d942ec07e27d4b01b 
>   src/sycoca/ksycocadict.cpp 2dc25d82506065910221e0ce191d8799d5a734fd 
>   src/sycoca/ksycocafactory.cpp b07e68870130c656d2b7b3d96977f4970cbec531 
>   src/sycoca/ksycocautils.cpp 87890d2416f490398e1cb4f11e6473672644fea4 
> 
> Diff: https://git.reviewboard.kde.org/r/124772/diff/
> 
> 
> Testing
> -------
> 
> compiles, unit tests pass
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150817/49ea0338/attachment.html>