Review Request 124746: [KDesktopFile] add readMimeType

Aleix Pol Gonzalez aleixpol at kde.org
Mon Aug 17 12:05:57 UTC 2015



> On Aug. 15, 2015, 9:24 p.m., David Faure wrote:
> > Why not use KService instead?
> 
> Kai Uwe Broulik wrote:
>     I don't know :) Seemed like the most reasonable way given I was checking the Desktop file for the exec path already.

KService is in Tier 3, KConfig is in Tier 1.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124746/#review83843
-----------------------------------------------------------


On Aug. 15, 2015, 7:38 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124746/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2015, 7:38 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> This allows to get the MimeType field of a desktop file to determin whether eg. the given application would accept a given mime type.
> 
> I'm not too happy about the name because "readMimeType" suggests it's a single item but then it's consisteht with the key name.
> 
> 
> Diffs
> -----
> 
>   src/core/kdesktopfile.cpp 254b59a 
>   autotests/kdesktopfiletest.cpp 1a9c1c3 
>   src/core/kdesktopfile.h 2190051 
> 
> Diff: https://git.reviewboard.kde.org/r/124746/diff/
> 
> 
> Testing
> -------
> 
> Test passes
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150817/b143593f/attachment.html>


More information about the Kde-frameworks-devel mailing list