Review Request 123376: Fix handling of mod-shift-number shortcuts.

[Thomas Lübking]

> On Mai 1, 2015, 7:51 vorm., Thomas Lübking wrote:
> > Two things.
> > a) "1" is a magic number (stupid xcb, should be xcppb ;-) - please add a comment that this picks the 1st level shift
> > b) the overall code looks a bit inefficient. No idea how smart xcb is under the hood, but
> >    1. we fetch the keysym via xcb_key_press_lookup_keysym
> >    2. we check the mod state to be numlock
> >    3. we fetch the keysym again (xcb_key_press_lookup_keysym just wraps xcb_key_symbols_get_keysym on ev->detail)
> >    4. we map keysymX to keysymQt
> >    5. we check the (mapped to Qt) modifier for the SHIFT flag
> >    6. this patch fetches and maps keysymX once more
> > .... do you want to do a general cleanup with this or another patch?
> 
> Yuxuan Shui wrote:
>     Hi, sorry for the later reply. I've been really busy later.
>     
>     I can do a code cleanup (will have some free time 2 weeks from now).  What do you want me to do.

I'm  not entirely sure which applies here (different for runtime and lib?) but next releases are due on
Thu 2015-08-20 and Sat 2015-09-5

I'd otherwise fix this up (wrt autotests "is possible") tomorrow otherwise.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123376/#review79753
-----------------------------------------------------------


On April 25, 2015, 7:54 nachm., Yuxuan Shui wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123376/
> -----------------------------------------------------------
> 
> (Updated April 25, 2015, 7:54 nachm.)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin and Thomas Lübking.
> 
> 
> Bugs: 341959
>     https://bugs.kde.org/show_bug.cgi?id=341959
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> For details, see discussion in corresponding bug report.
> 
> 
> Diffs
> -----
> 
>   src/runtime/kglobalaccel_x11.cpp abee5bc 
> 
> Diff: https://git.reviewboard.kde.org/r/123376/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yuxuan Shui
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150815/c8e00d2e/attachment.html>